Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(components): [button-group]: add direction prop #18906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
btea merged 17 commits into from
Nov 23, 2025
Merged

feat(components): [button-group]: add direction prop #18906

btea merged 17 commits into from
Nov 23, 2025

Conversation

@VisualYuki
Copy link
Contributor

@VisualYuki VisualYuki commented Nov 14, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

pull-request-triage bot commented Nov 14, 2024

👋 @VisualYuki, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Nov 14, 2024

Hello @VisualYuki, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2024 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18906

commit: 2efab80

@github-actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=18906
Please comment the example via this playground if needed.

@VisualYuki
Copy link
Contributor Author

VisualYuki commented Nov 14, 2024 •
edited
Loading

example

thinkasany
thinkasany reviewed Nov 14, 2024
View reviewed changes
@VisualYuki VisualYuki changed the title feat(components): [button-group]:add vertical direction for button group feat(components): [button-group]: add direction Nov 15, 2024
@VisualYuki
Copy link
Contributor Author

VisualYuki commented Nov 15, 2024 •
edited
Loading

@thinkasany updated example

@VisualYuki VisualYuki changed the title feat(components): [button-group]: add direction feat(components): [button-group]: add direction prop Nov 15, 2024
thinkasany
thinkasany reviewed Nov 17, 2024
View reviewed changes
@thinkasany
Copy link
Contributor

thinkasany commented Nov 17, 2024

@thinkasany updated example

I'm not a core member, you can request a review from @btea , their suggestions are more useful.I have submitted similar functions before, I hope it will be helpful to you. #18653

btea
btea reviewed Nov 20, 2024
View reviewed changes
@VisualYuki
Copy link
Contributor Author

VisualYuki commented Dec 5, 2024

@btea change npm version

btea
btea reviewed Jan 14, 2025
View reviewed changes
tolking
tolking approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

btea
btea reviewed Nov 19, 2025
View reviewed changes
@btea btea merged commit e3eff37 into element-plus:dev Nov 23, 2025
13 checks passed
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

@VisualYuki Thanks for your contribution! ❤️

@element-bot element-bot mentioned this pull request Nov 28, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@Dsaquel Dsaquel Dsaquel approved these changes

+1 more reviewer

@thinkasany thinkasany thinkasany left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@VisualYuki VisualYuki

Labels

CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VisualYuki @thinkasany @tolking @btea @Dsaquel