Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(components): [alert] add open and auto-close functionality with delays #20533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dsaquel merged 2 commits into from
May 24, 2025
Merged

feat(components): [alert] add open and auto-close functionality with delays #20533

Dsaquel merged 2 commits into from
May 24, 2025

Conversation

@betavs
Copy link
Contributor

@betavs betavs commented Apr 24, 2025

Please make sure these boxes are checked before submitting your PR, thank you!

close #5844

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

pull-request-triage bot commented Apr 24, 2025

👋 @betavs, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Apr 24, 2025

Hello @betavs, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 24, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/element-plus/element-plus@20533

commit: 178ae08

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=20533
Please comment the example via this playground if needed.

@betavs betavs force-pushed the feature/alert-delay-options branch 3 times, most recently from a6573c7 to ce61241 Compare April 30, 2025 02:23
btea
btea reviewed May 6, 2025
View reviewed changes
@betavs betavs force-pushed the feature/alert-delay-options branch from ce61241 to 4ae4aaf Compare May 6, 2025 10:20
@betavs betavs force-pushed the feature/alert-delay-options branch from 4ae4aaf to 18c05f4 Compare May 23, 2025 12:41
btea
btea reviewed May 23, 2025
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We can add a relevant example to the documentation.

@betavs
Copy link
Contributor Author

betavs commented May 23, 2025

We can add a relevant example to the documentation.

done

btea
btea approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dsaquel
Dsaquel approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@Dsaquel Dsaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dsaquel Dsaquel merged commit 0531cab into element-plus:dev May 24, 2025
13 checks passed
@element-bot element-bot mentioned this pull request Jun 6, 2025
Merged
3 tasks
@rzzf rzzf mentioned this pull request Sep 3, 2025
Closed
@warmthsea
Copy link
Member

warmthsea commented Oct 23, 2025

Taking a step back, I think the show-after and hide-after attributes shouldn't be added.
User event should provide immediate feedback.

This is incredibly strange and I think it's a bug.

No other UI library does this:

https://mui.com/material-ui/react-alert/#transitions
https://vuetifyjs.com/en/components/alerts/#closable
https://ant.design/components/alert-cn#alert-demo-closable
https://www.naiveui.com/zh-CN/os-theme/components/alert#closable.vue
https://daisyui.com/components/alert/
https://chakra-ui.com/docs/components/alert

warmthsea added a commit that referenced this pull request Oct 23, 2025
@warmthsea
Revert "feat(components): [alert] add open and auto-close functionali…
18cc3f2 
…ty with delays (#20533)"
@warmthsea warmthsea mentioned this pull request Oct 23, 2025
Merged
warmthsea added a commit that referenced this pull request Nov 17, 2025
@warmthsea
Revert "feat(components): [alert] add open and auto-close functionali…
cd2728a 
…ty with delay (#20533,#22028)" (#22560)

* Revert "fix(components): [alert] show immediately when `showAfter` not needed (#22028)"

This reverts commit 229a0a1.

* Revert "feat(components): [alert] add open and auto-close functionality with delays (#20533)"

* chore: update deprecated

* docs: update remark
@element-bot element-bot mentioned this pull request Nov 28, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@btea btea btea approved these changes

@Dsaquel Dsaquel Dsaquel approved these changes

Assignees

@betavs betavs

Labels

Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Auto Close option for Alert

4 participants

@betavs @warmthsea @btea @Dsaquel