Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(components): [image-viewer] add scale prop #22071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dsaquel merged 7 commits into from
Sep 17, 2025
Merged

feat(components): [image-viewer] add scale prop #22071

Dsaquel merged 7 commits into from
Sep 17, 2025

Conversation

@catanswer
Copy link
Contributor

@catanswer catanswer commented Sep 8, 2025

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 8, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/element-plus/element-plus@22071

commit: 019bac7

@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=22071
Please comment the example via this playground if needed.

btea
btea reviewed Sep 10, 2025
View reviewed changes
@btea btea changed the title feat(components): [image-viewer] add initialScale attribute feat(components): [image-viewer] add initial-scale prop Sep 10, 2025
btea
btea approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@catanswer catanswer closed this Sep 10, 2025
@catanswer catanswer deleted the feature-image-viewer branch September 10, 2025 05:32
@catanswer catanswer restored the feature-image-viewer branch September 10, 2025 05:37
@catanswer catanswer reopened this Sep 10, 2025
Dsaquel
Dsaquel reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@Dsaquel Dsaquel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some users will use initialScale synchronously while the preview is open, currently this scenario doesn't work. demo

@catanswer
Copy link
Contributor Author

catanswer commented Sep 15, 2025 •
edited
Loading

@Dsaquel has been modified

@Dsaquel
Copy link
Member

Dsaquel commented Sep 16, 2025

With the background of this PR i think we should name this prop scale in order to remove the ambiguity of the static default/initial data.

Dsaquel
Dsaquel reviewed Sep 16, 2025
View reviewed changes
Dsaquel
Dsaquel approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@Dsaquel Dsaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dsaquel
Dsaquel reviewed Sep 17, 2025
View reviewed changes
@Dsaquel Dsaquel enabled auto-merge (squash) September 17, 2025 15:05
@Dsaquel Dsaquel merged commit 8371dea into element-plus:dev Sep 17, 2025
13 checks passed
@Dsaquel Dsaquel changed the title feat(components): [image-viewer] add initial-scale prop feat(components): [image-viewer] add scale prop Sep 17, 2025
@element-bot element-bot mentioned this pull request Sep 19, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dsaquel Dsaquel Dsaquel approved these changes

@btea btea btea approved these changes

Assignees

@catanswer catanswer

Labels

Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@catanswer @Dsaquel @btea