feat(components): [color-picker-panel] hue-slider a11y #22258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
commit: |
|
Size Change: +273 B (+0.02%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
|
🧪 Playground Preview: https://element-plus.run/?pr=22258 |
Dsaquel
approved these changes
Sep 20, 2025
warmthsea
reviewed
Sep 22, 2025
btea
reviewed
Oct 7, 2025
btea
approved these changes
Oct 14, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the color picker panel's hue slider component with accessibility features and keyboard navigation improvements. The changes refactor the hue slider to use a shared slider composable with the alpha slider and add comprehensive keyboard support.
- Refactored hue slider to use shared
useSlidercomposable for consistency - Added keyboard navigation with Home, End, PageUp, PageDown keys for precise color control
- Enhanced accessibility with proper ARIA attributes and screen reader support for current color announcements
Reviewed Changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/locale/lang/*.ts | Added new localization keys for hue slider accessibility labels and descriptions |
| packages/components/color-picker-panel/src/props/slider.ts | Consolidated slider props and types for both alpha and hue sliders |
| packages/components/color-picker-panel/src/composables/use-slider.ts | Refactored into generic slider composable supporting both alpha and hue sliders |
| packages/components/color-picker-panel/src/components/hue-slider.vue | Complete rewrite using new composable with accessibility improvements |
| packages/components/color-picker-panel/src/components/alpha-slider.vue | Updated to use refactored composables and added accessibility features |
| packages/components/color-picker-panel/src/utils/draggable.ts | Removed preventDefault call to fix focus issues |
| packages/components/color-picker-panel/src/tests/color-picker-panel.test.tsx | Added test for hue slider keyboard navigation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.The hue slider is opposite in direction to the regular slider.
When controlled through the keyboard, I manually reverse it. But there will still be unreasonable behavior (press the ArrowUp key, but the value decreases).
Perhaps only by changing the design can this issue be completely fixed.