Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(components): [loading] allow setText to accept VNode type #22264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
btea merged 3 commits into from
Sep 21, 2025
Merged

fix(components): [loading] allow setText to accept VNode type #22264

btea merged 3 commits into from
Sep 21, 2025

Conversation

@rzzf
Copy link
Member

@rzzf rzzf commented Sep 20, 2025

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Rel #22025

@github-actions
Copy link

github-actions bot commented Sep 20, 2025 •
edited
Loading

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 20, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/element-plus/element-plus@22264

commit: cd267be

@github-actions
Copy link

github-actions bot commented Sep 20, 2025 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=22264
Please comment the example via this playground if needed.

@btea
Copy link
Member

btea commented Sep 21, 2025

Perhaps we could add a test case.

@rzzf
Copy link
Member Author

rzzf commented Sep 21, 2025

Perhaps we could add a test case.

Thanks, I’ve added the test.

btea
btea approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 231f126 into element-plus:dev Sep 21, 2025
13 checks passed
@rzzf rzzf deleted the fix/loading-setText branch September 21, 2025 02:20
@element-bot element-bot mentioned this pull request Sep 26, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@btea btea btea approved these changes

@Dsaquel Dsaquel Dsaquel approved these changes

Assignees

@rzzf rzzf

Labels

Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzzf @btea @Dsaquel