Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rzzf
Copy link
Member

@rzzf rzzf commented Sep 22, 2025

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/element-plus/element-plus@22281

commit: d75b974

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

🧪 Playground Preview: https://element-plus.run/?pr=22281
Please comment the example via this playground if needed.

@btea
Copy link
Member

btea commented Sep 22, 2025

It looks a bit similar to #22152.

@warmthsea
Copy link
Member

User requests are always strange.

How about changing it like this?

Only these two components are added. I don't think the other components need to be addressed.

@rzzf
Copy link
Member Author

rzzf commented Sep 22, 2025

User requests are always strange.

How about changing it like this?

Only these two components are added. I don't think the other components need to be addressed.

Okay.

@rzzf rzzf changed the title fix(components): [autocomplete] allow cyclic keyboard navigation feat(components): [autocomplete] add loopNavigation attributes Sep 22, 2025
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our new props should be added to the document at the same time.

Co-authored-by: btea <[email protected]>
@rzzf
Copy link
Member Author

rzzf commented Sep 23, 2025

Our new props should be added to the document at the same time.

Done.

Copy link
Member

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btea btea merged commit b197bbf into element-plus:dev Sep 23, 2025
13 checks passed
@rzzf rzzf deleted the fix/22280 branch September 23, 2025 09:35
@element-bot element-bot mentioned this pull request Sep 26, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component] [autocomplete] 弹窗键盘上下键切换选项没有循环

3 participants