Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(components): [date-picker] externalize formatToString #22349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
warmthsea merged 2 commits into from
Sep 29, 2025
Merged

refactor(components): [date-picker] externalize formatToString #22349

warmthsea merged 2 commits into from
Sep 29, 2025

Conversation

@Dsaquel
Copy link
Member

@Dsaquel Dsaquel commented Sep 27, 2025

close #14159

@github-actions
Copy link

github-actions bot commented Sep 27, 2025 •
edited
Loading

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 27, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/element-plus/element-plus@22349

commit: 82facaf

@github-actions
Copy link

github-actions bot commented Sep 27, 2025 •
edited
Loading

Size Change: -714 B (-0.05%)

Total Size: 1.55 MB

Filename Size Change
./dist/element-plus/dist/index.full.js 440 kB -196 B (-0.04%)
./dist/element-plus/dist/index.full.min.js 317 kB -189 B (-0.06%)
./dist/element-plus/dist/index.full.min.mjs 312 kB -166 B (-0.05%)
./dist/element-plus/dist/index.full.mjs 431 kB -163 B (-0.04%)
ℹ️ View Unchanged
Filename Size
./dist/element-plus/dist/index.css 46.1 kB

compressed-size-action

@github-actions
Copy link

github-actions bot commented Sep 27, 2025 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=22349
Please comment the example via this playground if needed.

@Dsaquel Dsaquel force-pushed the refactor/date-picker-externalize-formatToString branch from 3ca9bc8 to 82facaf Compare September 28, 2025 11:00
@Dsaquel
Copy link
Member Author

Dsaquel commented Sep 28, 2025

feat well with #22356

btea
btea approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

warmthsea
warmthsea approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warmthsea warmthsea merged commit 6eb677f into dev Sep 29, 2025
13 checks passed
@warmthsea warmthsea deleted the refactor/date-picker-externalize-formatToString branch September 29, 2025 09:39
@element-bot element-bot mentioned this pull request Oct 17, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@btea btea btea approved these changes

@warmthsea warmthsea warmthsea approved these changes

Assignees

@Dsaquel Dsaquel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dsaquel @btea @warmthsea