Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@keeplearning66
Copy link
Member

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

relate #22888

  1. I also noticed popper-offset prop. Should we apply it to the tooltip of the title as well?
  2. The description in the documentation about Popper Offset says Menu with popperOffset will override Submenu's popper-offset. Isn't this reversed? It should be Submenu with popperOffset will override Menu's popper-offset, right? 🤔

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

@github-actions
Copy link

Hello, @keeplearning66, your PR title does not meet the standards, please refer to here.
你好,@keeplearning66,你的 PR 标题不符合规范,请参考这里

@github-actions github-actions bot added the CommitMessage::Unqualified Unqualified commit message label Nov 24, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 24, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus/element-plus@22908

commit: d2ca0c0

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

🧪 Playground Preview: https://element-plus.run/?pr=22908
Please comment the example via this playground if needed.

@Dsaquel
Copy link
Member

Dsaquel commented Nov 26, 2025

The description in the documentation about Popper Offset says Menu with popperOffset will override Submenu's popper-offset. Isn't this reversed? It should be Submenu with popperOffset will override Menu's popper-offset, right?

It is, would you mind to update this too ?

I also noticed popper-offset prop. Should we apply it to the tooltip of the title as well?

I think it will be dangerous to edit that. Perhaps adding a new prop for this better.

@keeplearning66
Copy link
Member Author

It is, would you mind to update this too ?

Okay, it's updated.

I think it will be dangerous to edit that. Perhaps adding a new prop for this better.

If we need to add a new prop, maybe we could wait until a user requests it before handling it. The name of the prop might also need some discussion. WDYT ? 👀 👀

@Dsaquel
Copy link
Member

Dsaquel commented Nov 27, 2025

If we need to add a new prop, maybe we could wait until a user requests it before handling it. The name of the prop might also need some discussion. WDYT ? 👀 👀

You right, we can wait until a developer request 👍 .

@btea btea merged commit 32f8739 into element-plus:dev Dec 2, 2025
14 of 17 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

@keeplearning66 Thanks for your contribution! ❤️

@keeplearning66 keeplearning66 deleted the feat/apply-popper-to-tooltip-title branch December 2, 2025 02:10
@element-bot element-bot mentioned this pull request Dec 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants