Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
|
Does setting user@VirtualBox-17958d80:~/work/camera$ git diff
diff --git a/io.elementary.camera.yml b/io.elementary.camera.yml
index 29bdac1..b0ec129 100644
--- a/io.elementary.camera.yml
+++ b/io.elementary.camera.yml
@@ -19,6 +19,7 @@ finish-args:
- '--socket=pulseaudio'
- '--device=dri'
- '--device=all'
+ - '--env=GST_PLUGIN_PATH_1_0=/app/lib64/gstreamer-1.0'
- '--metadata=X-DConf=migrate-path=/io/elementary/camera/'
cleanup:
user@VirtualBox-17958d80:~/work/camera$ |
|
@ryonakano that does work thank you!! |
|
@ryonakano could I get a rereview? :) |
ryonakano
left a comment
There was a problem hiding this comment.
I haven't tested this yet, but leaving some comments.
Also, we need to update the README according with the meson.build and plus explicit that we now requires gst-plugins-rs as a runtime dependency.
Co-authored-by: Ryo Nakano <[email protected]>
Co-authored-by: Ryo Nakano <[email protected]>
|
Don't forget to update the readme! |
|
I just tested and it does work. The frame rate is a little better even! Not sure if that's due to whatever was causing error log spam being fixed but it is usable now! |
ryonakano
left a comment
There was a problem hiding this comment.
Confirmed that it can take photos and videos with my iSight camera.
Leaving another few tiny comments, otherwise looks good!
|
@danirabbit Sorry, please ignore my previous suggestions. Just modifying dependencies list in README.md is fine for me. |
|
@ryonakano I guess switching README to use Flatpak builder is the best thing to do here? #277 |
|
@danirabbit Then this PR looks good to me! |
Fixes #205