Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check fully for null doc in document change handler #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidmhewitt merged 2 commits into from
Mar 30, 2022
Merged

Check fully for null doc in document change handler #1146

davidmhewitt merged 2 commits into from
Mar 30, 2022

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Dec 7, 2021 •
edited
Loading

Since the document-change signature includes a nullable Document, the handler should avoid dereferencing it and fallback actions provided.

@jeremypw jeremypw mentioned this pull request Dec 29, 2021
Closed
@davidmhewitt davidmhewitt enabled auto-merge (squash) March 30, 2022 12:33
@davidmhewitt davidmhewitt merged commit 9db961a into master Mar 30, 2022
@davidmhewitt davidmhewitt deleted the extend-null-check branch March 30, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidmhewitt davidmhewitt davidmhewitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremypw @davidmhewitt