Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeremypw
Copy link
Collaborator

Fixes #1147

Replaces TextIter.backward_word_start () with our own function in order to regard hyphens and underscores as part of the string to match for completions.

@jeremypw jeremypw requested a review from igordsm December 15, 2021 16:26
@jeremypw jeremypw mentioned this pull request Dec 29, 2021
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm that this fixes the issue following the steps in your issue report, and with regular code files.

I am compiling this on the daily OS 7.0 images, so perhaps there has been a library change that affects this. Are you able to confirm whether this still fixes the issue for you?

@davidmhewitt davidmhewitt added the Status: Blocked Something else needs to be done before this can be fixed label Mar 30, 2022
@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 31, 2022

I can confirm the issue still occurs for me (UK locale) in elementary 6.1 and this PR fixes it. However, if it does not occur in elementary 7.0 due to upstream changes then we can close this PR.

@davidmhewitt
Copy link
Member

@jeremypw Sorry, what I mean is that this issue is still present on elementary OS 7, and this PR does not seem to fix it. I haven't tried on 6.1 yet.

Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion. It was my mistake in not re-installing the branch so that the new plugin was picked up. I can confirm that this works on both elementary 6.1 and 7, and the code looks good and makes sense.

Thanks for your work.

@davidmhewitt davidmhewitt merged commit 1e321b4 into master Apr 1, 2022
@davidmhewitt davidmhewitt deleted the completion-include-hyphen-underscore branch April 1, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Blocked Something else needs to be done before this can be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Word completion plugin does not handle underscores and hyphens as expected

4 participants