Fix drag and drop of accented text and between tabs #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2022 18:56
zeebok
approved these changes
Jun 9, 2022
Contributor
zeebok
left a comment
There was a problem hiding this comment.
Code looks good and works as described. My only thought with testing is maybe also open the file in a new tab if the file is dropped anywhere in the tab area instead of only the new document button.
Collaborator
Author
|
@zeebok Thanks for the review! I'll look into your suggestion in a separate PR. |
Collaborator
Author
|
@zeebok Actually, you can also drop files onto the blank area of the tabbar to create a tab with this PR. Changes would have to be made to the Granite library to implement dropping onto an existing tab (and it is not clear what the expected behaviour would be in that case). As Granite DynamicNotebook is likely to be replaced in the not too distant future I do not think it worth progressing this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1191
Fixes #1193
The linked issues are caused by resetting the source view as a drag destination to handle uri lists but without handling text properly. Attempts were made to handle uris with the sourceview without causing issues for buffer contents but these failed. It is much easier to keep the native DnD handling of the Gtk.SourceView and handle uri lists with the DocumentView.
The effect of this change is that in order to create a new document by dropping a file item (e.g. from Files) the target is the "Add Tab" button on the tab bar. Dropping elsewhere (e.g. on the textview) drops the uri as text.
In my opinion, this change is acceptable, despite the smaller target for uris, since (1) Dropping a file onto a sourceview has an ambiguous intent (drop uri as text? drop file contents as text? create new document???) and (2) it is not likely to be a commonly used action anyway.