EditorConfig plugin overrides global settings for indent width and style #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Aug 31, 2022
Member
danirabbit
left a comment
There was a problem hiding this comment.
Hm, this doesn't seem to work for me. When I open an xml file in a project with an editorconfig (such as code) I still get 4 space indent instead of 2
Collaborator
Author
|
@danrabbit It works for me under those circumstances. You have to have in the editor-config file (after the [*] setting) |
Collaborator
Author
|
Also you have to install the PR in order to update the plugin - or use the Flatpak version |
Collaborator
Author
|
Maybe this is another candidate for moving into the main code? |
danirabbit
approved these changes
Jan 12, 2023
Member
danirabbit
left a comment
There was a problem hiding this comment.
Works as expected, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1203
.editorconfigfile so that it does not duplicate/conflict with global setting of indent width and style.It was noticed that although
indent-widthandtab-widthare separate properties of SourceView, there is no facility in the existing code for these to be set separately so these are treated the same by the plugin (and only one specified in the config file). If both were specified in a config file then the last one would have priority. If there are situations where these need to be set separately additional code will be required.There is no facility to update the
.editorconfigfile through the UI (except by manual editing). That could be added as a future PR if required.Input required on the user facing copy.