Make sidebar pane the toplevel container #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@danirabbit Please could you fix conflicts, thanks. |
Member
Author
|
@jeremypw done! |
jeremypw
approved these changes
Jan 12, 2023
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
The only issue I have with this design is that the close window button is no longer visually separated from the sidebar so it looks like a "close sidebar" button. Not sure what the solution is to this (if one is needed) and it is not blocking for me.
Code looks good.
The function of the project chooser button probably needs review. It always reverts to the project related to the focused document regardless of what selection is attempted. However, that is for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1217
Fits the more modern design we've been moving towards with other apps: