Move Terminal to core #1225
Merged
Move Terminal to core #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
requested changes
Jan 13, 2023
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
Only one tiny comment inline. Otherwise looks good as a starting point for a review of the terminal functionality.
Possible refinements for future PRs:
- Easy way of navigating to (and/or opening at) active project's folder
- Separate terminal for each project open
- Built in common (customizable) commands e.g. for compiling, testing, debugging, building Flatpak, git etc
Collaborator
|
CI fail not due to these changes. |
jeremypw
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of being a plugin, move the Terminal into the main src directory. Also remove the unused bottom notebook which only this plugin was using.
Eventually can be used with #1223 to help fix #1082