FormatBar: use menubuttons instead of ToggleButtons #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
requested changes
Jan 13, 2023
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
Works as expected. Only one very picky comment; the variable names *_toggle should be changed e.g. to *_menubutton as they are no longer toggles.
There seems an issue with the labelling of the tab menubutton when tabs are being used rather than spaces. It changes from e.g. "4 spaces" to "4 tabs" but regardless of the settings the indent width is in fact 4 spaces; but it is achieved in different ways (4 space characters or 1 tab character). Not sure what the correct label should be though. Maybe "4 (space)" and "4 (tab)". Anyway, something for a separate PR probably.
jeremypw
approved these changes
Jan 14, 2023
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
Approving as bugs found were present in master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: