Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Headerbar: code style, small fixes #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 13 commits into from
Jan 16, 2023
Merged

Headerbar: code style, small fixes #1234

danirabbit merged 13 commits into from
Jan 16, 2023

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 14, 2023 •
edited
Loading

Review with "hide whitespace changes"

  • Inline namespace
  • Code style
  • Fix save button hiding when autosave is enabled
  • Use built-in feature for listening to a specific setting change
  • Leave a comment explaining public widget access
  • Box instead of Grid
  • Remove unnecessary show_all ()
  • Use Gtk.Application to get the active window

@danirabbit danirabbit requested a review from a team January 14, 2023 00:22
@zeebok zeebok assigned zeebok and unassigned zeebok Jan 16, 2023
@danirabbit danirabbit enabled auto-merge (squash) January 16, 2023 06:58
@danirabbit danirabbit merged commit d2ef5f1 into master Jan 16, 2023
@danirabbit danirabbit deleted the headerbar-cleanup branch January 16, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeebok zeebok zeebok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @zeebok