Additional Search options in menu #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 25, 2023 18:31
Member
|
@jeremypw can you resolve conflicts here? This is a huge improvement and I'd love to get this merged :) Also, can you make sure to add lines in metainfo.xml for these fixed issues |
added 3 commits
March 16, 2023 11:28
# Conflicts: # src/Widgets/SearchBar.vala
Collaborator
Author
|
Checking for regressions due to merging master. |
Collaborator
Author
|
There are some quirks in the searching but they seem to be present in master as well so can be fixed separately. |
danirabbit
previously approved these changes
Mar 23, 2023
Member
danirabbit
left a comment
There was a problem hiding this comment.
Touched up some style stuff, this looks awesome. Nice work!
danirabbit
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933
Fixes #1275
Fixes #1175 (bitesize)
Puts all current search options (Cyclic, Case Sensitive, Regex) into a menu and adds another (Whole Word). Also an additional Case Sensitive sub-option is implemented making the current Emacs mode optional. To this end a combobox with three choices replaces one of the switches.
Design input required: