Phew tomorrow took a bit to arrive but I did start testing! I did notice some things:

1. If I create a new file in Code and save it, edit it in terminal and return to code, it will not detect the changes and give me the option to reload. If I try to make changes and save (either with autosave or not) it tells me it cannot save the changes
2. If I get into the state in Issue 1, I cannot close the document tab. In fact, I need to kill Code because I can't even close that
3. These issues do not occur if you open an existing file in Code

@zeebok Thanks for looking at this! I am pretty sure it worked better than that when first pushed 😞 maybe the last merge messed it up. I'll have to see how this PR works with #1307 / #1308 too as there maybe some overlap.

@danirabbit In view of your comments on #1307, is this something that would also be better done with a dialog? The infobar now contains a lot of information in this PR.

@zeebok

If I create a new file in Code and save it, edit it in terminal and return to code, it will not detect the changes and give me the option to reload.

This is expected - Code does not continually monitor the file on disk, it only checks the file status when an edit is made and autosave is ON, or when a save is attempted. However, I confirm that the behaviour after a save attempt is made is unsatisfactory - no reason for the save failure is given. This in fact was the motivation for #1307 as it was happening under other circumstances.

The whole system for saving files in Code is quite tricky to work on.

Converting to draft pending decision regards dialog and whether to incorporate in #1308 (or at least develop together)

This is expected

But it does appear to do it with a file I load. I load a file in Code, edit it externally, and I get the message when I go back to Code.

But it does appear to do it with a file I load. I load a file in Code, edit it externally, and I get the message when I go back to Code.

Hmm, OK. Not sure why that should be but there are a lot of moving parts involved. I'll make sure to include the two possibilities in my testing. Hopefully #1309 handles this better.

@zeebok It seems your issue is caused by the "focus-in" handler not being connected for new documents after they are saved - fixing.

Closing in favor of #1309