Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jun 1, 2023

Towards addressing #1322

A separate PR is required to remove the option from the man page,

@danirabbit
Copy link
Member

@jeremypw does this still require a separate PR since #1325 was merged?

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 8, 2023

#1325 Did not alter the man page only changed the way it is installed so yes, after code support for this option is removed by this PR, the manpage needs updating. I could do it here as well though.

@jeremypw jeremypw requested a review from a team June 17, 2023 08:40
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeremypw jeremypw merged commit d104736 into master Jun 18, 2023
@jeremypw jeremypw deleted the remove-plugin-set-option branch June 18, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants