Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle only relevant settings key changes #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 2 commits into from
Jun 28, 2023
Merged

Handle only relevant settings key changes #1345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6bdf32
Handle only relevant settings key changes
Jun 27, 2023
cc6d687
Merge branch 'master' into improve-settings-handling
tintou Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Services/Document.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,11 @@ namespace Scratch.Services {
source_map.set_view (source_view);

hide_info_bar ();
set_minimap ();
set_strip_trailing_whitespace ();
settings.changed["show-mini-map"].connect (set_minimap);
settings.changed["strip-trailing-on-save"].connect (set_strip_trailing_whitespace);

restore_settings ();

settings.changed.connect (restore_settings);
/* Block user editing while working */
notify["working"].connect (() => {
source_view.sensitive = !working;
Expand Down Expand Up @@ -647,7 +648,7 @@ namespace Scratch.Services {
return true;
}

private void restore_settings () {
private void set_minimap () {
if (Scratch.settings.get_boolean ("show-mini-map")) {
source_map.show ();
scroll.vscrollbar_policy = Gtk.PolicyType.EXTERNAL;
Expand All @@ -656,7 +657,9 @@ namespace Scratch.Services {
source_map.no_show_all = true;
scroll.vscrollbar_policy = Gtk.PolicyType.AUTOMATIC;
}
}

private void set_strip_trailing_whitespace () {
if (Scratch.settings.get_boolean ("strip-trailing-on-save")) {
strip_trailing_spaces ();
}
Expand Down