Sync tab settings #1347
Merged
Sync tab settings #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
reviewed
Jul 9, 2023
zeebok
previously approved these changes
Jul 9, 2023
Contributor
zeebok
left a comment
There was a problem hiding this comment.
Code looks good and works as advertised. Besides my one question I think this is good to merge.
Collaborator
Author
|
@zeebok I have removed the clamp as you suggested and added a corresponding forced range to the schema. Also changed the range in the plugin to correspond. |
Collaborator
Author
|
I notice that |
zeebok
approved these changes
Jul 11, 2023
Contributor
zeebok
left a comment
There was a problem hiding this comment.
I notice that
geditonly allows tabs in the range 2 - 8 and also only even numbers.
Even seems nice but I don't feel strongly enough to not approve this. I think this is great and good customization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1340
There is a pre-existing issue that the range of the tab width spinbutton is up to 24 while the maximum tab width set by editorconfig plugin is 16. This should be resolved here or later.
As this PR changes a plugin, it needs to be installed for testing.