Store and restore active-project-path explicitly #1472
Conversation
* Sync with GitManager and ProjectChooserButton
danirabbit
left a comment
There was a problem hiding this comment.
I think this is actually worse because the project isn't updating when I switch project files, so project-wide search will continue to search in the old selection instead of the project that relates to the open files
|
@danirabbit Hmm, OK. I was trying to make the "active project" more stable and avoid conflict between what the terminal build directory is and what the active project is. May have to rethink the global search. It is not clear what to do if the user opens documents in more than one project at a time. I guess the search should be done in the project associated with the currently focussed document? I am reluctant to have the active project keep switching depending on which document is focussed! The active project, in my mind, is the one that is being developed and built. Agreed you might want to have documents from other projects open for reference but that does not change the focus of development. |
|
@danirabbit I have tried to address your concerns by decoupling the "active project path" from the "global search path". The main issue now is whether you want to be able to have different active projects in different windows. This could be useful I guess but would require having separate GitManager instances for each window. Only one of the window would be restorable at the moment. |
|
Converting to draft while fixing a bug in choosing active projects with same beginning of name. |
|
@danirabbit I would be grateful if you would reconsider the revised version of this PR. The project-wide search now follows the project associated with the focussed document as before, which I believe was you main concern. I have some uncertainty about what to do with "project" folders that are not git repos but this is probably not blocking as it pre-exists. Do we need to distinguish these as far as setting the terminal path or project button for example. At present in this PR the context menu for the project folder does differ but it would be simpler if it didn't so I am happy to revert that. |
zeebok
left a comment
There was a problem hiding this comment.
Looks good. Just a couple questions due to my ignorance of the codebase. I can test if you like before merge but I'm comfortable with just merging.
# Conflicts: # src/FolderManager/FileView.vala
Fixes #1471
See also #1518 - "Open in Terminal Pane" is a distinct action from "Set as Active Project" - it just changes the current directory in the Terminal Pane to the folder path whereas "Set as Active Project" has a number of effects including setting the current Terminal Pane directory to the default build path (not necessarily the folder (root) path).