Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor FolderManager code improvements #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremypw merged 13 commits into from
Mar 17, 2025
Merged

Minor FolderManager code improvements #1489

jeremypw merged 13 commits into from
Mar 17, 2025

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Nov 25, 2024 •
edited
Loading

  • Although unlikely for local files, FolderManager.File objects are not guaranteed to have a non-null FileInfo - this is now checked before dereferencing in is_valid_directory and icon.
  • No use is currently made of the ability to suppress hidden files in the folder (they are shown de-emphasised instead) so associated code is removed
  • is_valid_directory and is_valid_textfile are now both properties and are only determined once to improve performance.

@jeremypw jeremypw changed the title Jeremypw/minor code improvements Minor FolderManager code improvements Nov 25, 2024
@jeremypw jeremypw marked this pull request as ready for review November 25, 2024 22:08
@jeremypw jeremypw added the Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Feb 8, 2025
@jeremypw jeremypw requested a review from a team February 8, 2025 18:01
ryonakano
ryonakano reviewed Mar 4, 2025
View reviewed changes
@jeremypw jeremypw requested a review from ryonakano March 6, 2025 14:24
ryonakano
ryonakano reviewed Mar 15, 2025
View reviewed changes
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late review, another tiny thing and otherwise looks good.

@jeremypw jeremypw requested a review from ryonakano March 17, 2025 12:13
@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 17, 2025

@ryonakano Thanks for review! I've fixed that obviously unnecessary repetition.

@jeremypw jeremypw merged commit c793f08 into master Mar 17, 2025
6 checks passed
@jeremypw jeremypw deleted the jeremypw/minor-code-improvements branch March 17, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees

No one assigned

Labels

Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeremypw @ryonakano @zeebok