Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PluginManager: cleanup listbox, add accessible name #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 2 commits into from
May 21, 2025
Merged

PluginManager: cleanup listbox, add accessible name #1561

danirabbit merged 2 commits into from
May 21, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented May 21, 2025 •
edited
Loading

Screenshot from 2025-05-21 13 18 43

  • Add lots of line breaks. They are free and make things more legible :)
  • set accessible name on the list
  • There's no reason to limit content height on this scrollbox, it's in a resizable dialog
  • scrollbar policy is AUTOMATIC by default, no need to override it
  • Set margins on the row content, not on individual items in the box
  • Organize boxes. It's messy to initialize a box early and then go pack it later and makes it hard to keep track of how the box is packed. Keep that all together
  • Don't use a headerlabel here, it's not a header
  • Add ellipsize to labels in case the dialog is resized very small
  • Align the checkbox to the end

@danirabbit danirabbit requested a review from a team May 21, 2025 20:25
@danirabbit danirabbit merged commit dd75c21 into master May 21, 2025
6 checks passed
@danirabbit danirabbit deleted the danirabbit/pluginmanager-listbox-cleanup branch May 21, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardo-lemos leonardo-lemos leonardo-lemos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @leonardo-lemos