Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PluginsManager: cleanups #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 2 commits into from
May 21, 2025
Merged

PluginsManager: cleanups #1562

danirabbit merged 2 commits into from
May 21, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented May 21, 2025

  • Explicitly declare scope of private variables and methods
  • extension set can be private to the construct block
  • Fix code style of property accessors. get, then set. only declare scope if it overrides the property scope
  • Signals don't need a comment, they declare themselves to be signals
  • Object call on one line since it only has one argument

@danirabbit danirabbit requested a review from a team May 21, 2025 20:59
@danirabbit danirabbit merged commit a6d91fe into master May 21, 2025
6 checks passed
@danirabbit danirabbit deleted the danirabbit/pluginmanager-cleanups branch May 21, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardo-lemos leonardo-lemos leonardo-lemos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @leonardo-lemos