Show more information in Vala symbol tooltip #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Getting crash when starting up with certain documents/conditions although opening same documents from sidebar does not cause problems - diagnosing ... |
bf859d7 to
2764aec
Compare
Collaborator
Author
|
Looks like the crashing was due to accessing the source view from a separate parsing thread without locking it. This is now fixed. The parsing thread is now made to yield to the main thread after each child construction and this allows other documents to load and the UI to be used even though there is a document (e.g. a vapi) that takes a long time to finish parsing. Because of this the time allowed to construct the symbol pane has been increased. |
leonardo-lemos
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1410
It proved simpler and better to copy the definition from the document rather than trying to reconstruct from the parsed symbols. The tooltip includes text to the end of the first line pointed to by the symbol.source_reference as this may contain extra useful information such as parameters and/or comments.