Follow natural-copy-paste behaviour of pantheon-terminal #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Jun 2, 2025
|
|
||
| private void update_terminal_settings (string settings_schema) { | ||
| var pantheon_terminal_settings = new GLib.Settings (settings_schema); | ||
| pantheon_terminal_settings = new GLib.Settings (settings_schema); |
Member
There was a problem hiding this comment.
Since this key comes from another app, we should really check and make sure it exists before reading from it so we don't introduce a new crash
Collaborator
Author
There was a problem hiding this comment.
True, but pantheon_terminal_settings is already being used at several other places unrelated to this PR (getting "font", "audible-bell", "cursor-shape", "background", "foreground" and "palette" keys) so maybe dealing with the case that the Terminal schema has been uninstalled can be left to a separate PR covering all these cases?
danirabbit
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Copy code from Terminal