Bump libgit2-glib dependency #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-lemos
previously requested changes
Jun 25, 2025
Collaborator
leonardo-lemos
left a comment
There was a problem hiding this comment.
Can you also update the lib version in the Flatpak manifest, please?
Collaborator
Author
|
@leonardo-lemos Thanks - I am working on that but having trouble getting the flatpak to build atm. I'll revert to draft. |
Collaborator
Author
|
@leonardo-lemos Turns out that for some unreason the flatpak does not build with platform v8.1 or v8.2 but it builds with v7.1 and v8 so I bumped the platform to v8. I haven't bumped other modules like libgit2 or libssh2 so far. |
danirabbit
requested changes
Jun 26, 2025
io.elementary.code.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| app-id: io.elementary.code | |||
| app-id: io.elementary.code8 | |||
Member
There was a problem hiding this comment.
Can we revert the ID change here please :)
Collaborator
Author
There was a problem hiding this comment.
Oops, that was supposed to be a temporary change
danirabbit
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Code already cannot compile on OS7 (because of libpeas-2) we can bump the version of libgit2-glib used. On OS8 we no longer need to carry the
.vapieither as it is now in/usr/share/vala