Properly handle callback suggestion #265
Conversation
|
Is it possible to add a test for this? |
|
I'll try. Maybe I can push the test in a week or two when dialyzer finishes "Building core Dialyzer Elixir PLT" :) |
| ] | ||
| }) | ||
| }), | ||
| 300 |
There was a problem hiding this comment.
Without that, I get timeouts all the time.
|
@axelson done. Testing |
|
Not sure why it breaks in the CI server. Locally, a get all green:
As I told you, I have a very bad dev experience running the tests. Some tests run fine on my machine but not on the CI server, other tests run on the CI server but not on my machine :( |
Thanks for adding some tests! I am totally with you on that the current state of the test suite is quite poor. Unfortunately I too get test failures locally that I haven't been able to track down, and the tests are quite noisy (lots of output to stdout). Some of the tests are a bit flaky on CI as well. Although I did just submit #270 which cleans up the test output quite a bit. That particular test looks to be failing because this PR doesn't actually update elixir_sense to get elixir-lsp/elixir_sense#99 I have some changes locally that I'll push up to this branch that will make the tests not depend on the standard library and update elixir_sense. |
|
Fantastic! You're my hero :) Feel free to merge it whenever you're done with your changes. Cheers. |
Properly handle callback suggestions (with or without
def/defmacrobefore the cursor).Requires elixir-lsp/elixir_sense#99, otherwise, suggestions will not appear after typing
"d","de"or"def".