Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New suggestions engine #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 26, 2020
Merged

New suggestions engine #99

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8b8d92
New suggestion engine based on reducers
msaraiva May 23, 2020
7c5275a
Run formatter
msaraiva May 23, 2020
0036271
Update test to check only vars in struct update
msaraiva May 23, 2020
ec79faa
Fix dialyzer and credo
msaraiva May 23, 2020
56d374f
Update docs for Suggestion
msaraiva May 23, 2020
2e8484c
Run formatter
msaraiva May 23, 2020
ac6d1ea
Improve callback suggestion
msaraiva May 23, 2020
013f490
Do not list callbacks inside functions
msaraiva May 24, 2020
f86845a
Allow other suggestions for struct update syntax
msaraiva May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions lib/elixir_sense.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,7 @@ defmodule ElixirSense do
...> end
...> '''
iex> ElixirSense.suggestions(code, 3, 12)
[%{type: :hint, value: "MyList.insert_at"},
%{origin: "List", type: :function, args: "list, index, value", arity: 3, name: "insert_at", metadata: %{},
[%{origin: "List", type: :function, args: "list, index, value", arity: 3, name: "insert_at", metadata: %{},
spec: "@spec insert_at(list, integer, any) :: list", summary: "Returns a list with `value` inserted at the specified `index`."}]
"""
@spec suggestions(String.t(), pos_integer, pos_integer) :: [Suggestion.suggestion()]
Expand All @@ -164,15 +163,7 @@ defmodule ElixirSense do

env = Metadata.get_env(buffer_file_metadata, line)

Suggestion.find(
hint,
env,
buffer_file_metadata.structs,
buffer_file_metadata.mods_funs_to_positions,
buffer_file_metadata.types,
buffer_file_metadata.specs,
text_before
)
Suggestion.find(hint, text_before, env, buffer_file_metadata)
end

@doc """
Expand Down
Loading