Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chrome headless and binary opts can be passed in @sessions #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhanberg merged 2 commits into from
Jul 12, 2023
Merged

Chrome headless and binary opts can be passed in @sessions #736

mhanberg merged 2 commits into from
Jul 12, 2023

Conversation

@dvic
Copy link
Contributor

@dvic dvic commented Jul 11, 2023 •
edited
Loading

This makes it possible to override headless and binary for a particular test, e.g.,

@sessions [[headless: false]]
feature "my feature", %{session: session} do 
  ...
end

@mhanberg
Copy link
Member

mhanberg commented Jul 12, 2023

Can you edit the Wallaby.Feature docs to mention you can pass these options?

@dvic
Copy link
Contributor Author

dvic commented Jul 12, 2023

Can you edit the Wallaby.Feature docs to mention you can pass these options?

Done!

mhanberg
mhanberg reviewed Jul 12, 2023
View reviewed changes
@dvic dvic force-pushed the chrome-opts-override branch from 8a997a8 to 0afa477 Compare July 12, 2023 19:25
@mhanberg
Copy link
Member

mhanberg commented Jul 12, 2023

Have you tested this locally with a real project?

@dvic
Copy link
Contributor Author

dvic commented Jul 12, 2023

Have you tested this locally with a real project?

Yup

@mhanberg mhanberg merged commit 389d416 into elixir-wallaby:main Jul 12, 2023
@mhanberg
Copy link
Member

mhanberg commented Jul 12, 2023

Thanks!

@dvic dvic deleted the chrome-opts-override branch July 12, 2023 19:57
alinmarsh pushed a commit to TernSystems/wallaby that referenced this pull request Oct 8, 2024
@dvic @alinmarsh
Chrome headless and binary opts can be passed in @sessions (elixir-wa…
49a904a 
…llaby#736)

* Chrome headless and binary opts can be passed in @sessions

* New options are documented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhanberg mhanberg mhanberg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvic @mhanberg