-
Notifications
You must be signed in to change notification settings - Fork 30
Add SQL Server and EF Core migrations guides for persistence configuration #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sfmskywalker <[email protected]>
Co-authored-by: sfmskywalker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds comprehensive documentation for SQL Server persistence and Entity Framework Core migrations in Elsa Workflows v3, directly addressing user confusion around database configuration and custom migration workflows. The PR fulfills its goal of providing clear, provider-specific guidance while maintaining consistency with existing documentation patterns.
Key Changes
- New SQL Server Guide: Complete 472-line guide covering NuGet packages, configuration, connection strings, migration deployment, troubleshooting, and production considerations
- New EF Core Migrations Guide: Comprehensive 661-line guide explaining Elsa's DbContext architecture, custom entity integration patterns, migration strategies, and version upgrade workflows
- Enhanced Navigation: Added persistence guides to SUMMARY.md and cross-linked from database configuration and Docker guides
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| guides/persistence/sql-server.md | Comprehensive SQL Server setup guide with configuration examples, troubleshooting, and production best practices (addresses #2, #11) |
| guides/persistence/ef-migrations.md | Detailed EF Core migrations guide covering custom entities, DbContext patterns, and migration strategies (addresses #74, references elsa-core #6355) |
| guides/persistence/README.md | Updated with cross-links to new SQL Server and EF Core Migrations guides |
| getting-started/database-configuration.md | Enhanced with references to new comprehensive persistence guides |
| getting-started/containers/docker-compose/persistent-database.md | Added "See Also" section with links to database and persistence documentation |
| getting-started/containers/docker-compose/docker-quickstart.md | Added cross-references to database configuration and persistence guides |
| SUMMARY.md | Added SQL Server and EF Core Migrations entries under Persistence section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@copilot apply changes based on the comments in this thread |
- Add missing using directive for SqlConnectionStringBuilder - Replace TrustServerCertificate with Encrypt in environment examples Co-authored-by: sfmskywalker <[email protected]>
All changes from the review thread have already been applied in commit 63751c6:
|
Implementation Complete - Persistence Documentation (PR 3)
✅ All Requirements Met
New Documentation Created:
guides/persistence/sql-server.md(472 lines) - Complete SQL Server setup guideguides/persistence/ef-migrations.md(661 lines) - Complete EF Core migrations guideNavigation & Cross-linking:
SUMMARY.mdwith new guide linksguides/persistence/README.mdwith links to new guidesgetting-started/database-configuration.mdpersistent-database.mddocker-quickstart.mdQuality Validation:
Issues Addressed:
Original prompt
Implement "PR 3" from our prior planning for elsa-workflows/elsa-gitbook.
Goal: Introduce a clear, user-focused persistence documentation set covering supported providers (SQL Server, PostgreSQL, MongoDB, etc.) and how to configure EF Core migrations for Elsa. This should directly address:
Repository: elsa-workflows/elsa-gitbook
Base branch: main
Requirements:
Add a persistence providers overview
guides/persistence/README.md.sql-server.md,postgresql.md,mongo.md) and the EF migrations guide.Add a SQL Server-specific guide (explicitly addressing [DOC] How to use SQLServer instead of SqlLite in Els3.0? #2)
guides/persistence/sql-server.md.Microsoft.EntityFrameworkCore.SqlServer).Program.cssnippet using the current Elsa v3 API to switch from SQLite to SQL Server, including both Workflow Runtime and Workflow Management modules.UseEntityFrameworkCoreandUseSqlServer(or equivalent) in the right places.elsa-corerepo (e.g., from the main server sample and/or module extensions).configuration.GetConnectionString("Elsa")).Add an EF Core migrations guide (addresses Generating Custom EF Core Migrations #74)
guides/persistence/ef-migrations.md.dotnet efat them).dotnet ef migrations addanddotnet ef database updateagainst the host project.csproj/Program.csexample that will work with the current Elsa 3.x setup inelsa-core.Wire these guides into navigation
SUMMARY.mdto add a new "Persistence" section under an appropriate place (e.g., after Core Concepts or Setup/Guides):guides/persistence/README.md(e.g., "Persistence Providers")guides/persistence/sql-server.md(e.g., "SQL Server")guides/persistence/ef-migrations.md(e.g., "EF Core migrations")Cross-link from related pages
guides/persistence/README.md).guides/persistence/sql-server.mdto avoid duplication, orConsistency and scope
elsa-gitbook(headings, admonitions, code fences, etc.).This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.