Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add shortcut indicators to sections #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jkdufair
Copy link
Contributor

A small enhancement. Show shortcut indicators (if specified) for each section. Open to suggestions. Useful? Add font-lock?

image

@JesusMtnez
Copy link
Contributor

@jkdufair again, thank you for your contribution 😄 I really like the idea.

@jkdufair
Copy link
Contributor Author

Thanks @JesusMtnez. I'll get the linter errors fixed. Any idea if there is a better way than (eval-when-compile (defvar...?

@jkdufair
Copy link
Contributor Author

LOL I just moved the defcustom to the widgets file itself.

@JesusMtnez
Copy link
Contributor

@jkdufair what would happen if there is no keybinding for that widget (for example, custom widgets) ?

@JesusMtnez
Copy link
Contributor

Also @rakanalh and @jdkufair, I think it would be great if this feature is enabled by default, it does not break anything and it is a good looking thing for the package. What do you think?

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkdufair

I think having it enabled by default is a good idea.

@jkdufair
Copy link
Contributor Author

jkdufair commented Mar 1, 2019

Ok, I will do it. Along those lines, what if we were to enable a header face by default? I just use font-lock-function-name-face for my own dashboard.

image

@jkdufair
Copy link
Contributor Author

jkdufair commented Mar 1, 2019

@JesusMtnez I'll check on what happens with no keybinding as well. I don't think it currently handles it.

@jkdufair
Copy link
Contributor Author

jkdufair commented Mar 1, 2019

Verified that custom sections without shortcuts do not cause problems.

@JesusMtnez
Copy link
Contributor

@jkdufair thank you so much!

@JesusMtnez
Copy link
Contributor

Ok, I will do it. Along those lines, what if we were to enable a header face by default? I just use font-lock-function-name-face for my own dashboard.

image

We could address that in another PR 😉

JesusMtnez and others added 2 commits March 1, 2019 08:40
Update docs to reflect jump indicators are enabled by default

Co-Authored-By: jkdufair <[email protected]>
@JesusMtnez JesusMtnez merged commit ff9e6e5 into emacs-dashboard:master Mar 1, 2019
@jkdufair jkdufair deleted the feature/shortcut-indicators branch March 1, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants