Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/header faces #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2019

Conversation

jkdufair
Copy link
Contributor

@jkdufair jkdufair commented Mar 1, 2019

Addresses #108

JesusMtnez
JesusMtnez previously approved these changes Mar 1, 2019
@JesusMtnez
Copy link
Contributor

@jkdufair to avoid breaking changes, take a look at: define-obsolete-face-alias

That way, you should be able to define an alias to the old name to indicate it is obsolete. You could set this change is included since version 1.2.6 (which will be the release containing this change).

What do you think?

@jkdufair
Copy link
Contributor Author

jkdufair commented Mar 1, 2019

Oh interesting. Or do you think we are better to just leave it alone? @JesusMtnez

@JesusMtnez
Copy link
Contributor

I like the idea of doing things right, and we have a proper way of doing it

@jkdufair
Copy link
Contributor Author

jkdufair commented Mar 1, 2019

Great. I'll get it implemented!

@jkdufair
Copy link
Contributor Author

jkdufair commented Mar 3, 2019

@JesusMtnez Everything look ok?

@JesusMtnez
Copy link
Contributor

@jkdufair Everything looks good! Thank you!

@JesusMtnez JesusMtnez merged commit 0bd7e81 into emacs-dashboard:master Mar 3, 2019
@jkdufair jkdufair deleted the feature/header-faces branch March 4, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants