Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support bookmark/agenda/register/project actions. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019
Merged

Support bookmark/agenda/register/project actions. #131

merged 1 commit into from
May 24, 2019

Conversation

seagle0128
Copy link
Contributor

Fix #130: change widget type.

@seagle0128 seagle0128 changed the title Support bookmark/agenda/register actions. Support bookmark/agenda/register/project actions. May 23, 2019
Copy link
Contributor

@JesusMtnez JesusMtnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@@ -508,7 +507,7 @@ date part is considered."
register-alist
list-size
"e"
(lambda (&rest ignore) (jump-to-register (car el)))
(lambda (&rest _ignore) (jump-to-register (car el)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no '(lambda (&rest ignore) (jump-to-register (car el))) as in the rest of sections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, others should be changed to _ignore as well to clean the warnings.

@JesusMtnez
Copy link
Contributor

This should also fix #133

@JesusMtnez JesusMtnez merged commit f19a1ed into emacs-dashboard:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks and agenda doesn't work
2 participants