-
-
Notifications
You must be signed in to change notification settings - Fork 141
Added foot note plus several enhancements and code improvements #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks fine with me except one minor issue above. Thank you! |
What issue? Emmacs? That's not an error jaja, my name is Emmanuel, Emma in short so I like to mess calling Emacs Emmacs. By the way I also modified the text banners face to match the headings and also enabled the init info for it which wasn't enabled. I tried to use your center-line function but I couldn't understand how it worked so I used the piece of code that was originally on dashboard to center the content as the center-line function calling it before instead of after the centered text. |
Sorry! I started a code-review but forgot to submit the comments.
Regarding |
By the way regarding the dashboard-navigator customization I was thinking about implementing it and came with the idea that the user passes an alist with the icon they want for the button, the text they want in it and the internal/external link that button accesses and that dashboard automatically built the navigator. I don't now how to make a "triple" alist though. Would you help me with an idea? |
@ema2159 (defvar dashboard-navigator-alist
'(("tag1" action1 "help1" face1 ...)
("tag2" action2 "help2" face2 ...)))
The essential items should be tag and action, so it could be (defvar dashboard-navigator-alist
'(("tag1" . action1)
("tag2" . action2))) The widget style of the buttons is Does that address your issue? |
Yes! I'll try that, that'll make Dashboard a really complete and aesthetic package, more than it is right now. From there I don't know what enhancements can be done. |
@JesusMtnez I think this PR is good to go! |
Thank you @ema2159 !! This is a really good job. I'll be busy tomorrow, but it'll try to merge it on Sunday or on Monday. |
@JesusMtnez no hay prisa! Do it when you can! |
Do you mind moving this last commit to it's own PR? |
Of course! It's only two lines tho so is it worth it? |
Thank you @ema2159 !! |
Created a customizable footnote with its own customizable icon. Respected the most I could @seagle0128 implementation in Centaur to try and not mess up his cool config. It looks like this:

Also, improved a little bit the order of the code with things like for example generalizing the banner title, init info and foot note centering with a function.
Hope you like it and approve it! Please test it