-
-
Notifications
You must be signed in to change notification settings - Fork 141
Add the navigator below the banner with the customized buttons. #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Mr. Zhang! Yes I'll review it as soon as I can. It seems that the test for Emacs 25 isn't passing, it's probably due to a malformed expression caused by some macro that isn't available for Emacs 25 (i.e. when-let) |
@ema2159 The compatibility issue of Emacs 25 has been addressed. |
@seagle0128 Yes! you fixed it like 3 seconds before I commented it |
Also, it could be pretty nice to add and option to configure the brackets to allow the user to remove them or maybe change their faces, like maybe give the user access to the button-prefix/suffix in the widget create function and also add the option to customize the icon face separtely. Besides from that it's a very very nice addition and it works pretty well, I personally like it a lot. |
@ema2159 I think it's crowed for the page header. I got the screenshots below. I prefer the last one. If all like the first, I will change it.
I will try to add an option and commit soon. |
Thank you @seagle0128 for this!! Looks pretty good!!
I prefer the first one π . If all the widgets are enabled, I would rather see them than having that extra space. |
It's really subjective, I also prefer the first one but also understand Mr. Zhang. How big is your monitor tho @seagle0128 π ? I work with a pretty big one and I don't have that much space jaja! |
OK. I understand what you concern. I make it compact for now. An option can be added in future if necessary. |
Yeah!!! Really happy to implement this in BTW, may need multiple lines of navigator, and the option I think it's ready to go now! Please merge, @JesusMtnez . |
@seagle0128 Again, really good job here! Thank you!! Also, thank you @ema2159 also for all your support and contributions too. I'll proceed to merge this |
@JesusMtnez @ema2159 , I port the navigator feature from my
Centaur Emacs
. Please review and merge. Thanks!To show navigator below the banner:
To customize the buttons of the navigator like this: