Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support multiple lines for the navigator. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

Support multiple lines for the navigator. #150

merged 1 commit into from
Jun 7, 2019

Conversation

seagle0128
Copy link
Contributor

Fix #148 .

;; Format: "(icon title help action face prefix suffix")
(setq dashboard-navigator-buttons
      `(;; line1
        ((,(all-the-icons-octicon "mark-github" :height 1.1 :v-adjust 0.0)
         "Homepage"
         "Browse homepage"
         (lambda (&rest _) (browse-url "homepage")))
        ("★" "Star" "Show stars" (lambda (&rest _) (show-stars)) warning)
        ("?" "" "?/h" #'show-help nil "<" ">"))
         ;; line 2
        ((,(all-the-icons-faicon "linkedin" :height 1.1 :v-adjust 0.0)
          "Linkedin"
          ""
          (lambda (&rest _) (browse-url "homepage")))
         ("⚑" nil "Show flags" (lambda (&rest _) (message "flag")) error))))

image

@seagle0128
Copy link
Contributor Author

@ema2159 @JesusMtnez please review.

JesusMtnez
JesusMtnez approved these changes Jun 6, 2019
View reviewed changes
@JesusMtnez
Copy link
Contributor

@seagle0128 Great job! Thank you!!

@ema2159
Copy link
Contributor

ema2159 commented Jun 6, 2019

@seagle0128 it works really well just as expected! It's good to go.
By the way, the background of your Centaur Logo gives me anxiety jajaja is it intended?

@seagle0128
Copy link
Contributor Author

seagle0128 commented Jun 7, 2019 •
edited
Loading

@ema2159 The logo is transparent, but it's not good view with emacs-plus. It's good with the vanilla Emacs. Do you know the reason?

@JesusMtnez It's ready to merge. Thank you!

@JesusMtnez
Copy link
Contributor

Thank you @seagle0128 again for this wonderful PR. Merge on its way!

@JesusMtnez JesusMtnez merged commit ad4c7b1 into emacs-dashboard:master Jun 7, 2019
@ema2159
Copy link
Contributor

ema2159 commented Jun 7, 2019

@ema2159 The logo is transparent, but it's not good view with emacs-plus. It's good with the vanilla Emacs. Do you know the reason?

@JesusMtnez It's ready to merge. Thank you!

Wow that's really odd, I opened your logo in Photoshop (please forgive me Richard Stallman) and it is transparent but the size of the png (the square) is exactly as it's shown in your dashboard. I personally don't use Mac. What an odd bug 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusMtnez JesusMtnez JesusMtnez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could it be possible to put navigator buttons on different lines?
3 participants
@seagle0128 @JesusMtnez @ema2159