Create a custom variable for dashboard-footer #186
Conversation
|
You're right, I made those changes some time ago when I was an Emacs newbie, they work but are a somewhat hardcoded. There's two things though:
|
|
Ok do those things. I'm just learning how to submit PRs and use git, so I've accidentally included an extra commit here. I'll fix this momentarily. |
|
Don't worry! It's good that you're willing to learn |
|
Is this all set to merge or is there something more to be done from me? |
|
Probably Mr. Martinez missed it or forgot about it, so ask him directly! (@JesusMtnez ) Maintaining a repo like this is quite difficult in fact. |
|
Sorry, I have been pretty busy during the past few months, lots of personal changes right now. I will catch up with all the new issues and pull requests after the holidays, sorry for the delay and thank you for your patience. And, of course, Happy New Year 😉 |
|
I think this PR should be merged? It looks reasonable. |
In general, I think it's a bad idea to calculate
dashboard-footeror other information that's going to be on the dashbaord in adefvarordefcustom(any setter) form. This makes these values harder/more annoying to customize. Don't get me wrong you can still customize them, but the calculations will be done before you've even had a chance to decide you want them.