Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Text startup banner. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Text startup banner. #246

merged 3 commits into from
Oct 29, 2020

Conversation

jcs090218
Copy link
Member

This is the same as #157. I opened another PR because the old PR has been a while and I have deleted the branch.

@jcs090218 jcs090218 self-assigned this Oct 29, 2020
@jcs090218 jcs090218 mentioned this pull request Oct 29, 2020
@jcs090218 jcs090218 requested a review from JesusMtnez October 29, 2020 05:20
Copy link
Contributor

@JesusMtnez JesusMtnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@JesusMtnez
Copy link
Contributor

Why the CI is not running for this branch?

@jcs090218
Copy link
Member Author

Why the CI is not running for this branch?

It's kind of weird. I have checked circleci's website. It does run for each commitment but aren't showing on the commits page. ๐Ÿ˜•

Anyway, I realized there are multiple PRs having the same issue. For instance,

#233 - has the CI running
#238 - CI isn't running, including this PR.


Any ideas? ๐Ÿ˜• ๐Ÿ˜•

@jcs090218
Copy link
Member Author

Merged this PR now. Let me open an issue about the CI isn't running!

@jcs090218 jcs090218 merged commit 92722fd into emacs-dashboard:master Oct 29, 2020
@jcs090218
Copy link
Member Author

I have toggle the PR build from circleci page. I think the CI works in PR for now! ๐Ÿ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants