Use project-switch-commands for project-el backend of dashboard widget
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The project package built into Emacs 27 is too old; refer to Gnu Elpa’s version instead.
- Instead of always prompting which file to load, let the user choose from the list of actions that `project-switch-project` uses.
project-switch-commandsproject-switch-commands for project-el backend of dashboard widget
|
Sorry, I think there are conflict after this PR #232. Can you resolve it for us? Thank you! |
|
Thanks for explaining it! I thought this PR was different to #232. 😅 Thanks for the contribution! I appreciated! ;) |
|
It does something different than #232, but just replaces one hard-coded behavior with another one. #232 enables the user to choose the behavior themselves, so I think having the two project backends behave in the same way by default (i.e., prompt which file to open) is better overall for the project. Thanks for working on dashboard! It's my default buffer for each new tab, and very useful overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project package has a command
project-switch-projectwhich lets the user choose first a project and then a command from a customizable list; e.g. find a file, open magit, start a shell, etc.This pull request implements presenting the same list of commands from the project widget when
dashboard-projects-backendis set toproject-el, instead of always prompting for a file to open.