Restore Emacs 26 support #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `image-type-available-p` and `image-type` instead of `image-supported-file-p` as that function only exists in Emacs 29.
2c138ad to
c6f7524
Compare
jcs090218
approved these changes
Nov 17, 2022
|
LGTM! Thanks! @seagle0128 Does this patch work for you? |
|
Okay, I am merging this since @channel-42 has confirmed it works! |
|
It works, thank you! |
phdenzel
added a commit
to phdenzel/phd-dashboard
that referenced
this pull request
Feb 9, 2023
* 'master' of github.com:emacs-dashboard/emacs-dashboard: (21 commits) Inherit height on agenda entries from dashboard-items-face. (emacs-dashboard#435) Updated dashboard-filter-agenda-by-time w/help @ricardoricho Fixed issue wherein all previous entries showed. fix: Make sure we don't interfere init-info (emacs-dashboard#429) fix(centering): Caculate line length in pixel width (emacs-dashboard#427) docs(README.md): Update Eask's link Update copyright year fix: Revert display newline on footer (emacs-dashboard#424) tests: Avoid actions' warnings Add default script directive Use non-interactive for deleteing char (emacs-dashboard#422) Workaround for incorrect center text calculation (emacs-dashboard#420) fix: don't assume that PNGs are supported (emacs-dashboard#418) Setup node is no longer required Avoid `(pred (not` as it isn't supported before Emacs 28. (emacs-dashboard#416) Fix dashboard centering when both an image and text are specified (emacs-dashboard#415) Fix dashboard banner face (emacs-dashboard#412) Minor fix for point-at-bol/eol Restore Emacs 26 support (emacs-dashboard#409) changelog ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
image-type-available-pandimage-typeinstead ofimage-supported-file-pas that function only exists in Emacs 29.