-
-
Notifications
You must be signed in to change notification settings - Fork 141
Add ascii option to dashboard-startup-banner #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit.
Otherwise, LGTM. 👍
Would that suffice? Sorry, I had to change the commit message after pushing; I figured the initial message was a bit too open-ended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Thanks for your contribution!
I tested this out and noticed that the ASCII dashboard now is horizontally aligned to that the start of the banner is at the center, whereas before it was that the center of the of the banner was at the center. |
Not sure I follow @6b6279 (I'm not great with elisp). I tried adding |
I was talking about the |
Gotcha, thanks! |
@6b6279 Forgot to mention, would you like to open a PR for documentation? |
@jcs090218 Documentation? You mean like a short snippet in the README file on how to use the ASCII banner setting? |
@6b6279 👍 |
Should close #404.
I have done some rudimentary testing.
(put-text-property (point) (point-max) 'face 'dashboard-text-banner)
seems to not format the text added throughinsert
in line 597. Why that’s the case, I unfortunately do not know. Any tips are welcome.