Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix spillover bug from #436 #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Fix spillover bug from #436 #440

merged 1 commit into from
Feb 20, 2023

Conversation

6b6279
Copy link
Contributor

@6b6279 6b6279 commented Feb 20, 2023

See comments in #436.

Due to a discrepancy in point behavior between insert and insert-file-contents, insert must be called in a save-excursion block to ensure that the point remains unchanged.

Ensure that insert doesn't move point in dashboard-insert-banner when using ascii banner
Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thank you! 👍

@jcs090218 jcs090218 merged commit 221ee4b into emacs-dashboard:master Feb 20, 2023
@6b6279 6b6279 deleted the issue-404-spillover branch February 20, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants