Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Forcing color inversion for PDFs with pages that are entirely images #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jdogzz opened this issue Nov 30, 2020 · 4 comments
Closed

Forcing color inversion for PDFs with pages that are entirely images #453

Jdogzz opened this issue Nov 30, 2020 · 4 comments

Comments

@Jdogzz
Copy link

Jdogzz commented Nov 30, 2020

Is your feature request related to a problem? Please describe.
I have found the PDF color inversion to work perfectly for example PDFs which consist of text with images throughout. However, for PDFs which are full page images, the color inversion does not activate and leaves the document rendered as it originally appears. To the best of my knowledge, the color inversion keybinding i has no effect on documents that fit this criteria (I seem to presently be suffering from #237 but I have been able to successfully toggle color inversion on other documents which consist of text with some images, so I think I would have been able to do the same with the documents that are full page images). I have gone through the list of keybindings and see no alternative color inversion which would force documents like this to be inverted.

Describe the solution you'd like
I would like to have a key binding which forcefully applies the color inversion irrespective of regions classified as images.

Describe alternatives you've considered
Another possible acceptable solution is to add a third toggle when using i which cycles through: dark (leave images alone), dark (including images), original color.

@manateelazycat
Copy link
Member

@HollowMan6 can you look this issue?

@MatthewZMD
Copy link
Member

@HollowMan6 Can you add a variable that exclude #308 changes?

@HollowMan6
Copy link
Contributor

@HollowMan6 Can you add a variable that exclude #308 changes?

Ok, but I'm busy with exams this week, and I'll look into this at the weekends when I have time.

@HollowMan6
Copy link
Contributor

Hi @Jdogzz , I've made the patch #457 adopting your alternative solution cuz I think it's a better way. Please feel free if you have any other suggestions. Thanks!

manateelazycat pushed a commit that referenced this issue Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants