Add DynamicTga and ConvertColor #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to revert the same change to |
|
Yes, I would like to keep the APIs of |
|
I thought that might be the case :). I agree it doesn't belong in this PR. |
This was referenced Oct 26, 2020
Merged
jamwaffles
requested changes
Oct 30, 2020
Co-authored-by: James Waples <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for helping out with Embedded Graphics development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) and appropriate crate (embedded-graphics,simulator,tinytga,tinybmp) if your changes affect the public APIrustfmton the projectjust build(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
This PR adds
DynamicTgawhich is the first part of #424. The implementation depends on the color conversion suggested in #446, so I've also included that in this PR.I've also decided to revert a change I made in #430, where I merged
TgaandTgaRaw. Keeping them separate results in a cleaner API and I'm not sure why I decided to change that in the first place.