Thanks to visit codestin.com
Credit goes to github.com

Skip to content

modifyAssetLocation is not called for paths starting with ".." #416

Description

@lfloyd117

Right here ember-cli-code-coverage skips calling modifyAssetLocation if the path starts with .. because it assumes it is correct by manner of being in a monorepo.
https://github.com/ember-cli-code-coverage/ember-cli-code-coverage/blob/master/packages/ember-cli-code-coverage/lib/attach-middleware.js#L107-L109

A little bold to assume it is always correct. As I understand it, modifyAssetLocation is an entirely optional configuration so the developer can override the paths if ember-cli-code-coverage doesn't get it quite right. Whether in or out of a monorepo this should be no different.
In my case (and the case of others), we need to adjust it and just end up having to do so after tests run via bash script rather than being able to just configure it here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions