Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Dec 20, 2024

Advance #09772 to the Ready For Release Stage

Rendered

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

  • PR to Accepted Stage: #09772

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

  • Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
  • Any necessary learning materials have been updated
  • The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
  • The feature may not yet have support by the entire ecosystem (e.g. IDEs, addons, Ember Inspector, Engines, Lint Rules, Blueprints, etc), but it does not unintentionally break any existing functionality in those areas.
  • The Interactive Tutorial is not broken by this feature.
  • Criteria for moving to the Recommended Stage has been filled out
  • This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
  • Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
    • Framework @emberjs/framework
    • Data @emberjs/ember-data-core
    • CLI @emberjs/cli
    • Learning @emberjs/learning-core
    • Typescript @emberjs/typescript-core
    • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

  1. Add a page to the Ember Guides to cover "Build Tooling" that points at the Vite docs and explains the basics of how we're using Vite (like the presence of the ember plugin, etc).
  2. Add a banner to the old ember-cli guides that points at the new Build Tooling page.
  3. For command that shouldn't work in the new format (like ember test -s) we should update them to give a good error message.
  4. Somewhere (release notes? A guides page?) we need upgrade notes that explain the status of ember-cli-update and the existence of the codemod.
  5. Warn when using --yarn on generation with the new blueprint (it is not supported)
  6. --lang option lacks error handling in 6.8.0-beta ember-cli/ember-cli#10828
  7. Search guides and API docs for mentions of:

Track Implementation

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage labels Dec 20, 2024
@kategengler
Copy link
Member

@mansona Would you mind filling out this tracking PR?

@mansona mansona changed the title Advance RFC #09772 "v2 App Format" to Stage Ready for Release Advance RFC #0977 "v2 App Format" to Stage Ready for Release Jun 16, 2025
@ef4
Copy link
Contributor

ef4 commented Oct 3, 2025

We need to address at least the outstanding bugs in ember-cli/ember-cli#10814 like

  • ember test hanging

@mansona
Copy link
Member

mansona commented Oct 6, 2025

In the implementation the checkbox

Ensure generating with classic blueprint works and is documented somewhere

will be fixed by ember-cli/ember-cli#10824 which has CI failing because of embroider-build/ember-auto-import#665 which has a fix embroider-build/ember-auto-import#667

I was reluctant to merge through the failing CI because it was a patch to RELEASE but since the patch is literally just adding a package.json keywords entry I think it's safe 🤔 @kategengler what do you think?

@kategengler
Copy link
Member

@mansona I'd merge through it -- can it be released, though, with failing CI?

@mansona
Copy link
Member

mansona commented Oct 6, 2025

can it be released, though, with failing CI?

Yes, you just need to be able to merge regardless 👍 it's a branch protection override rule for PRs

@kategengler
Copy link
Member

I should have said: should we release, even though CI is failing?

@kategengler kategengler marked this pull request as ready for review October 7, 2025 20:31
@kategengler kategengler requested review from a team October 7, 2025 20:31
@ef4 ef4 merged commit 5572745 into main Oct 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Comment Period RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants