Remove auto-import from the app-template #2507
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
044865c to
d103dd8
Compare
NullVoxPopuli
commented
Aug 28, 2025
| @@ -24,8 +24,8 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: ./.github/actions/setup | |||
| - name: lint | |||
| run: pnpm lint | |||
| # - name: lint | |||
There was a problem hiding this comment.
temporary -- do not allow merge without uncommenting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the repro that @ef4 asked for in embroider-build/ember-auto-import#659
Note
This fake auto-import dependency will need to be added to all ember projects with the
classicEmberSupport()plugin.This
is still a simpler solution - but has a requirement: in order for it to be the solution, folks would need to set an override/resolution to force a single copy of ember-auto-import across their dependency graph so that all copies no-op (this is what I do in all my projects, but I can understand folks not wanting to do that).
Important
Merging this PR closes embroider-build/ember-auto-import#659 forever! 🎉